jdeppe-pivotal commented on a change in pull request #6907:
URL: https://github.com/apache/geode/pull/6907#discussion_r718697556
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/parameters/SpopParameterRequirements.java
##########
@@ -18,18 +18,22 @@
import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER;
import static org.apache.geode.redis.internal.netty.Coder.bytesToLong;
+import java.util.function.BiConsumer;
+
import org.apache.geode.redis.internal.netty.Command;
import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
-public class SpopParameterRequirements implements ParameterRequirements {
- @Override
- public void checkParameters(Command command, ExecutionHandlerContext
context) {
- if (command.getProcessedCommand().size() == 3) {
- try {
- bytesToLong(command.getProcessedCommand().get(2));
- } catch (NumberFormatException nex) {
- throw new RedisParametersMismatchException(ERROR_NOT_INTEGER);
+public class SpopParameterRequirements {
Review comment:
Good point - I've made that change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
