DonalEvans commented on a change in pull request #6861:
URL: https://github.com/apache/geode/pull/6861#discussion_r718019879
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSetCommandsFunctionExecutor.java
##########
@@ -175,10 +174,7 @@ public long zrevrank(RedisKey key, byte[] member) {
public long zunionstore(RedisKey destinationKey, List<ZKeyWeight> keyWeights,
ZAggregator aggregator) {
List<RedisKey> keysToLock = getKeysToLock(destinationKey, keyWeights);
- for (ZKeyWeight kw : keyWeights) {
- getRegionProvider().ensureKeyIsLocal(kw.getKey());
- keysToLock.add(kw.getKey());
- }
+
getRegionProvider().ensureKeyIsLocal(destinationKey);
keysToLock.add(destinationKey);
Review comment:
These two lines are also duplicated in the `getKeysToLock()` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
