agingade commented on a change in pull request #6914:
URL: https://github.com/apache/geode/pull/6914#discussion_r719789472
##########
File path:
geode-core/src/main/java/org/apache/geode/management/internal/operation/OperationHistoryManager.java
##########
@@ -95,13 +95,13 @@ private static boolean isExpired(long expirationTime,
OperationState<?, ?> opera
return operationEnd.getTime() <= expirationTime;
}
- private OperationState<?, ?> validateLocator(OperationState<?, ?>
operationState) {
- if (isLocatorOffline(operationState)) {
- operationState.setOperationEnd(new Date(), null,
+ private OperationState<?, ?> validateLocatorAndUpdateOperationState(
+ OperationState<?, ?> operationState) {
+ if (operationState.getOperationEnd() == null &&
isLocatorOffline(operationState)) {
Review comment:
Good catch @dschneider-pivotal
Removed the "operationState.getOperationEnd() == null" in isLocatorOffline()
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
