DonalEvans commented on a change in pull request #6925: URL: https://github.com/apache/geode/pull/6925#discussion_r720601277
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/string/AbstractMSetExecutor.java ########## @@ -0,0 +1,70 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.string; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; + +import java.util.ArrayList; +import java.util.List; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.data.RedisKeyExistsException; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + + +public abstract class AbstractMSetExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + + List<byte[]> commandElems = command.getCommandArguments(); + RedisStringCommands stringCommands = context.getStringCommands(); + + int numElements = commandElems.size() / 2; + List<RedisKey> keys = new ArrayList<>(numElements); + List<byte[]> values = new ArrayList<>(numElements); + + RedisKey previousKey = null; + for (int i = 0; i < commandElems.size(); i += 2) { + RedisKey key = new RedisKey(commandElems.get(i)); + + if (previousKey != null && key.getBucketId() != previousKey.getBucketId()) { Review comment: The approach we've been taking so far is to always match native Redis' behaviour (as seen by the user, at least) unless we're unable to do so for some reason. An example is how Redis handles integer value inputs from users, where they reject any values starting with + or the value -0 and return an error. We could in theory parse such values with no problem and not return an error, but the decision was made to match Redis' behaviour in this case, despite the fact that we could quite easily accept a wider range of inputs. (See `Coder.parseLong()`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
