jdeppe-pivotal commented on a change in pull request #6933:
URL: https://github.com/apache/geode/pull/6933#discussion_r721769032
##########
File path:
geode-apis-compatible-with-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/server/CommandIntegrationTest.java
##########
@@ -73,6 +76,25 @@ public void commandReturnsResultsMatchingNativeRedis() {
softly.assertAll();
}
+ @Test
+ public void
commandDoesNotReturnUnsupported_whenUnsupportedCommandsAreDisabled() {
+ radishServer.setEnableUnsupportedCommands(false);
+ try {
+ Map<String, CommandStructure> results =
processRawCommands(radishClient.command());
+
+ // Find an unsupported command
+ RedisCommandType someUnsupported =
Arrays.stream(RedisCommandType.values())
+ .filter(RedisCommandType::isUnsupported).findFirst()
+ .orElseThrow(() -> new AssertionFailedError("Could not find any
UNSUPPORTED commands"));
+
+ for (CommandStructure meta : results.values()) {
+ assertThat(meta.name).isNotEqualToIgnoringCase(someUnsupported.name());
+ }
+ } finally {
+ radishServer.setEnableUnsupportedCommands(true);
+ }
Review comment:
Thanks - I've updated per your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
