jchen21 commented on a change in pull request #6919:
URL: https://github.com/apache/geode/pull/6919#discussion_r723673464
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/filter/SanctionedSerializablesFilterPattern.java
##########
@@ -108,6 +108,22 @@ private static StringJoiner dependenciesPattern() {
.add("sun.security.provider.certpath.SunCertPathBuilderException")
// geode-modules
- .add("org.apache.geode.modules.util.SessionCustomExpiry");
+ .add("org.apache.geode.modules.util.SessionCustomExpiry")
+ // geode-dunit
+ .add("org.apache.geode.management.JmxLocatorReconnectDistributedTest*")
+ .add("org.apache.geode.management.JmxServerReconnectDistributedTest*")
+
.add("org.apache.geode.management.internal.rest.ManagementRequestLoggingDistributedTest*")
+
.add("org.apache.geode.internal.metrics.MeterSubregistryReconnectDistributedTest*")
+
.add("org.apache.geode.internal.io.LocatorLauncherGlobalGlobalSerialFilterDistributedTest*")
+
.add("org.apache.geode.internal.cache.CompactOfflineDiskStoreDUnitTest*")
+
.add("org.apache.geode.internal.cache.ParallelDiskStoreRecoveryDUnitTest*")
+
.add("org.apache.geode.internal.cache.PartitionedRegionSingleHopDUnitTest*")
+ .add("org.apache.geode.internal.cache.BucketServerLocation66")
+
.add("org.apache.geode.internal.cache.ValidateOfflineDiskStoreDUnitTest*")
+
.add("org.apache.geode.logging.internal.LoggingWithReconnectDistributedTest*")
+ .add("org.apache.geode.distributed.HostedLocatorsDUnitTest*")
+
.add("org.apache.geode.management.internal.cli.commands.ShutdownCommandDUnitTest*")
+
.add("org.apache.geode.management.internal.cli.commands.ShutdownCommandOverHttpDUnitTest*")
+ .add("org.apache.geode.test.dunit.**");
Review comment:
Addressed by setting system properties `jdk.serialFilter` to `*`.
##########
File path:
geode-core/src/integrationTest/java/org/apache/geode/internal/io/ServerJdkGlobalSerialFilterIntegrationTest.java
##########
@@ -64,6 +65,8 @@ public void setUp() throws IOException {
}
@Test
+ @Ignore
+ // jdk.serialFilter does not apply to ServerLauncher
Review comment:
`ServerJdkGlobalSerialFilterIntegrationTest.java` is renamed to
`ServerGlobalSerialFilterIntegrationTest.java` (without the string `jdk`).
Then it is split into two files, one file
`ServerGlobalSerialFilterIntegrationTest.java` without setting system property
`jdk.serialFilter` in its tests. The other file
`ServerSetSystemPropertyGlobalSerialFilterIntegrationTestset` sets the system
property `jdk.serialFilter` for each test method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
