jchen21 commented on a change in pull request #6988: URL: https://github.com/apache/geode/pull/6988#discussion_r727566850
########## File path: geode-core/src/test/java/org/apache/geode/internal/InternalDataSerializerShiroAcceptListTest.java ########## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.internal; + +import static java.util.Collections.emptySet; +import static org.apache.geode.distributed.internal.DistributionConfig.VALIDATE_SERIALIZABLE_OBJECTS_NAME; +import static org.apache.geode.internal.lang.ClassUtils.isClassAvailable; +import static org.apache.geode.internal.serialization.KnownVersion.CURRENT; +import static org.junit.Assume.assumeTrue; + +import java.io.ByteArrayInputStream; +import java.io.DataInputStream; +import java.io.IOException; +import java.util.Properties; + +import org.apache.shiro.ShiroException; +import org.apache.shiro.authc.AuthenticationException; +import org.apache.shiro.authz.AuthorizationException; +import org.apache.shiro.codec.CodecException; +import org.apache.shiro.config.ConfigurationException; +import org.apache.shiro.crypto.UnknownAlgorithmException; +import org.apache.shiro.dao.InvalidResourceUsageException; +import org.apache.shiro.env.RequiredTypeException; +import org.apache.shiro.io.SerializationException; +import org.apache.shiro.ldap.UnsupportedAuthenticationMechanismException; +import org.apache.shiro.session.SessionException; +import org.apache.shiro.session.StoppedSessionException; +import org.apache.shiro.subject.ExecutionException; +import org.junit.BeforeClass; +import org.junit.Test; +import org.junit.experimental.categories.Category; + +import org.apache.geode.DataSerializer; +import org.apache.geode.distributed.internal.DistributionConfig; +import org.apache.geode.distributed.internal.DistributionConfigImpl; +import org.apache.geode.test.junit.categories.SecurityTest; +import org.apache.geode.test.junit.categories.SerializationTest; + +@Category({SecurityTest.class, SerializationTest.class}) +public class InternalDataSerializerShiroAcceptListTest { + + @BeforeClass + public static void hasObjectInputFilter() { + assumeTrue("ObjectInputFilter is present in this JVM (post- 8.111)", Review comment: 8u121 ########## File path: geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java ########## @@ -177,6 +178,11 @@ * Do not add to this list unless absolutely necessary. Instead, put your classes either in the * sanctionedSerializables file for your module or in its excludedClasses file. Run * AnalyzeSerializables to generate the content for the file. + * + * <p> + * Syntax is documented by the javadocs of {@code ObjectInputFilter.Config.createFilter}. In + * Java 8, {@code ObjectInputFilter} is in package {@code sun.misc}. In Java 11, it's in package Review comment: In Java 9 and above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
