mmartell commented on a change in pull request #884:
URL: https://github.com/apache/geode-native/pull/884#discussion_r732061918



##########
File path: ci/base/base.yml
##########
@@ -72,7 +72,7 @@ builds:
     with_dot_net: #@ True
     #@yaml/map-key-override
     params:
-      CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv141,version=14.16,host=x64 
-DCMAKE_SYSTEM_VERSION=10.0.16299.0"
+      CMAKE_CONFIGURE_FLAGS: "-A x64 -Tv142,version=14.29,host=x64 
-DCMAKE_SYSTEM_VERSION=10.0.19041.0"

Review comment:
       We could use .. for CMAKE_CONFIGURE_FLAGS, which will utilize the latest 
toolchain installed on the system. However, it seems prudent to stick with the 
explicit tools versions to insulate us from unexpected issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to