jvarenina commented on a change in pull request #6036: URL: https://github.com/apache/geode/pull/6036#discussion_r733739023
########## File path: geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySenderState.java ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.geode.cache.wan; + +/* + * GatewaySenderState doesn't reflect current state, but the desired state of GatewaySender + * at the startup of the member. This state is only persisted within cluster configuration when + * start, stop, pause or resume gateway-sender command is successfully executed. When member starts + * again, it will read the state from cluster configuration and bring gateway-sender + * that desired state. + */ +public enum GatewaySenderState { Review comment: Hi @kirklund, thanks you for the review. Yes, GatewaySenderState is only used at sender startup. I like the name that you proposed as it describes this parameter more correctly. GatewaySenderState is a little bit misleading as someone could assume that it reflects current state of gateway-sender which is not correct. So I will rename it as you suggested. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
