jdeppe-pivotal commented on a change in pull request #7019:
URL: https://github.com/apache/geode/pull/7019#discussion_r737806788
##########
File path:
geode-for-redis/src/commonTest/java/org/apache/geode/redis/internal/proxy/RedisProxyInboundHandler.java
##########
@@ -129,6 +133,13 @@ public void channelRead(final ChannelHandlerContext ctx,
Object msg) {
outboundHandler.addResponseProcessor(nodesResponseProcessor);
}
break;
+ case "hello":
+ // Lettuce tries to use RESP 3 if possible but Netty's Redis codecs
can't handle that yet.
+ // We implicitly fake the client into thinking this is an older
Redis so that it uses
+ // RESP 2.
+ RedisMessage error = new ErrorRedisMessage("ERR unknown command");
Review comment:
Lettuce just cares that an error is returned. There doesn't seem to be
any benefit in adding more detail to the error response at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
