pivotal-jbarrett commented on a change in pull request #888:
URL: https://github.com/apache/geode-native/pull/888#discussion_r740199943



##########
File path: ci/lib/templates.lib.txt
##########
@@ -203,6 +203,9 @@ git_rev=$(git rev-parse HEAD)
 popd
 version=$(cat version/number)
 builddate=$(date "+%Y-%m-%d")
+(@- if use_vcvarsall: @)
+remote_shell "c:/Program Files (x86)\Microsoft Visual 
Studio/2019/Community/VC/Auxiliary/Build/vcvarsall.bat" x64 10.0.16299.0 
-vcvars_ver=14.20

Review comment:
       How are these env changes surviving past this single invocation of the 
command processor?
   
   Needed my vcvars is a heavy hammer. A small fix to ACE CMake file should 
pass all you need to ACE.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to