dschneider-pivotal commented on a change in pull request #7080:
URL: https://github.com/apache/geode/pull/7080#discussion_r743422663
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/netty/ByteToCommandDecoder.java
##########
@@ -51,16 +53,16 @@
public class ByteToCommandDecoder extends ByteToMessageDecoder {
public static final String UNAUTHENTICATED_MAX_ARRAY_SIZE_PARAM =
- "gemfire.geode-for-redis-unauthenticated-max-array-size";
+ RedisProperties.UNAUTHENTICATED_MAX_ARRAY_SIZE;
public static final String UNAUTHENTICATED_MAX_BULK_STRING_LENGTH_PARAM =
- "gemfire.geode-for-redis-unauthenticated-max-bulk-string-length";
+ RedisProperties.UNAUTHENTICATED_MAX_BULK_STRING_LENGTH;
private static final int MAX_BULK_STRING_LENGTH = 512 * 1024 * 1024; // 512
MB
// These 2 defaults are taken from native Redis
public static final int UNAUTHENTICATED_MAX_ARRAY_SIZE =
- Integer.getInteger(UNAUTHENTICATED_MAX_ARRAY_SIZE_PARAM, 10);
+ getIntegerSystemProperty(UNAUTHENTICATED_MAX_ARRAY_SIZE_PARAM, 10, 1);
public static final int UNAUTHENTICATED_MAX_BULK_STRING_LENGTH =
- Integer.getInteger(UNAUTHENTICATED_MAX_BULK_STRING_LENGTH_PARAM, 16384);
+ getIntegerSystemProperty(UNAUTHENTICATED_MAX_BULK_STRING_LENGTH_PARAM,
16384, 1);
Review comment:
They could. At the time I didn't because they are public and I worried
that they were used outside of the geode code base. But they probably are not
so I'll try getting rid of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
