albertogpz commented on pull request #7108: URL: https://github.com/apache/geode/pull/7108#issuecomment-970408879
> same comments as @mhansonp . Would need some unit tests for the refactor. @mhansonp and @jinmeiliao I have added unit test cases. Anyhow, I was not very fond of adding them because in order to add them, I have open up the implementation by adding a new public method (getExecutorService()) to be able to override it in the spy I am using in the test. I would have preferred to add a new constructor for testing to the class in which I could inject the dependencies for testing but it was not possible with gfsh command classes (at least, I did not find a way to do it). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
