nabarunnag commented on a change in pull request #7121:
URL: https://github.com/apache/geode/pull/7121#discussion_r751583645
##########
File path:
geode-junit/src/main/java/org/apache/geode/codeAnalysis/AnalyzeDataSerializablesTestBase.java
##########
@@ -230,10 +222,18 @@ private void serializeAndDeserializeObject(Object object)
throws Exception {
BufferDataOutputStream outputStream = new
BufferDataOutputStream(KnownVersion.CURRENT);
try {
serializeObject(object, outputStream);
- } catch (IOException e) {
+ } catch (IOException | NullPointerException e) {
// some classes, such as BackupLock, are Serializable because the extend
something
// like ReentrantLock but we never serialize them & it doesn't work to
try to do so
System.out.println("Not Serializable: " + object.getClass().getName());
+ return;
+ } catch (Exception e) {
+ // please don't hate me... geode-membership cannot load
CacheClosedException
Review comment:
No hate :) but I think we can put the message in the sys out below
mentioning that geode-membership cannot load this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
