jdeppe-pivotal commented on a change in pull request #7115:
URL: https://github.com/apache/geode/pull/7115#discussion_r754451359
##########
File path:
geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/executor/string/StringsKillMultipleServersDUnitTest.java
##########
@@ -49,10 +50,19 @@
@BeforeClass
public static void classSetup() {
MemberVM locator = cluster.startLocatorVM(0);
- cluster.startRedisVM(1, locator.getPort());
- cluster.startRedisVM(2, locator.getPort());
- cluster.startRedisVM(3, locator.getPort());
- cluster.startRedisVM(4, locator.getPort());
+ int locatorPort = locator.getPort();
+ cluster.startRedisVM(1, x -> x
+ .withConnectionToLocator(locatorPort)
+ .withProperty(REDUNDANCY_ZONE, "A"));
+ cluster.startRedisVM(2, x -> x
+ .withConnectionToLocator(locatorPort)
+ .withProperty(REDUNDANCY_ZONE, "B"));
+ cluster.startRedisVM(3, x -> x
+ .withConnectionToLocator(locatorPort)
+ .withProperty(REDUNDANCY_ZONE, "A"));
+ cluster.startRedisVM(4, x -> x
+ .withConnectionToLocator(locatorPort)
+ .withProperty(REDUNDANCY_ZONE, "B"));
Review comment:
So in that scenario the test would still pass but wouldn't be testing
the right thing. However given that the likelihood of that happening is so
incredibly small (pretty sure its around 1:2^64) I don't think it's worth
over-complicating the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
