jinmeiliao commented on a change in pull request #7116:
URL: https://github.com/apache/geode/pull/7116#discussion_r758628245
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/security/SecurityServiceFactory.java
##########
@@ -51,6 +53,11 @@ public static SecurityService create(Properties
securityProps, CacheConfig cache
public static SecurityService create(Properties securityProps,
SecurityManager preferredSecurityManager, PostProcessor
preferredPostProcessor) {
+ String securityServiceClassName =
System.getProperty(SECURITY_SERVICE_SYSTEM_PROPERTY);
+ if (securityServiceClassName != null) {
Review comment:
We will need to simulate a cache closed scenario while calling the
"authorized" method, this can't be done in the `SecurityManager`. The only way
to reproduce this in a predicable way is to plug in a test security service
object. I have tried testing it the other way, none of them can guarantee the
failure to happen.
I will put the logic in a method that clearly indicate this is for testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
