DonalEvans commented on a change in pull request #7157:
URL: https://github.com/apache/geode/pull/7157#discussion_r760631817
##########
File path:
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/set/AbstractSDiffIntegrationTest.java
##########
@@ -55,12 +59,34 @@ public void sdiffErrors_givenTooFewArguments() {
}
Review comment:
Using a sorted set is a bit iffy, because native Redis does support
doing diff/union/inter of a mixture of sorted sets and sets, but we don't
currently support that in geode-for-redis. It'd be best to use a string,
something like:
```
@Test
public void sdiff_withNonSetKey_throwsWrongtypeError() {
jedis.sadd("{user1}set1", "member");
jedis.set("{user1}string1", "value");
assertThatThrownBy(() -> jedis.sdiff("{user1}set1", "{user1}string1"))
.hasMessage("WRONGTYPE Operation against a key holding the wrong
kind of value");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
