dschneider-pivotal commented on a change in pull request #7105:
URL: https://github.com/apache/geode/pull/7105#discussion_r762352224



##########
File path: 
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/delta/AddsDeltaInfo.java
##########
@@ -24,14 +24,11 @@
 import java.util.List;
 
 import org.apache.geode.DataSerializer;
+import org.apache.geode.internal.InternalDataSerializer;
 
 public class AddsDeltaInfo implements DeltaInfo {

Review comment:
       It could be done but I don't think it should. The DeltaInfo name should 
describe what they contain. It is possible for the same DeltaInfo class to be 
used by multiple operations so even though, currently, this one is only used by 
SADD I think its current name is good: it is a DeltaInfo that contains one or 
more "add" operations. The ones with plural names can contain more than one 
item.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to