DonalEvans commented on a change in pull request #7164:
URL: https://github.com/apache/geode/pull/7164#discussion_r764280361
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -242,6 +242,7 @@
SADD(new SAddExecutor(), SUPPORTED, new Parameter().min(3).flags(WRITE,
DENYOOM, FAST)),
SDIFF(new SDiffExecutor(), SUPPORTED,
new Parameter().min(2).lastKey(-1).flags(READONLY, SORT_FOR_SCRIPT)),
+ SISMEMBER(new SIsMemberExecutor(), SUPPORTED, new
Parameter().exact(3).flags(READONLY, FAST)),
Review comment:
The correctness of the RedisCommandType flags is tested and validated
against native Redis in `CommandIntegrationTest`, and the parameters are tested
in the `sismemberWrongNumberOfArguments_returnsError` test in
`AbstractSIsMemberIntegrationTest`, so we have comprehensive coverage of this
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
