jchen21 commented on a change in pull request #7167: URL: https://github.com/apache/geode/pull/7167#discussion_r763321983
########## File path: geode-core/src/main/java/org/apache/geode/internal/serialization/filter/DistributedSerializableObjectConfig.java ########## @@ -0,0 +1,45 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.internal.serialization.filter; + +import static java.util.Objects.requireNonNull; +import static org.apache.geode.distributed.ConfigurationProperties.SERIALIZABLE_OBJECT_FILTER; +import static org.apache.geode.distributed.ConfigurationProperties.VALIDATE_SERIALIZABLE_OBJECTS; + +import java.util.Properties; + +public class DistributedSerializableObjectConfig implements SerializableObjectConfig { + + private final Properties config; + + public DistributedSerializableObjectConfig(Properties config) { + this.config = requireNonNull(config); + } + + @Override + public boolean getValidateSerializableObjects() { + return "true".equalsIgnoreCase(config.getProperty(VALIDATE_SERIALIZABLE_OBJECTS)); + } + + @Override + public void setValidateSerializableObjects(boolean value) { + config.setProperty(VALIDATE_SERIALIZABLE_OBJECTS, Boolean.valueOf(value).toString()); + } + + @Override + public String getSerializableObjectFilter() { Review comment: Might also need a setter `setSerializableObjectFilter` at some point, when the user set `serializable-object-filter`. ########## File path: geode-serialization/src/main/java/org/apache/geode/internal/serialization/filter/SanctionedSerializables.java ########## @@ -62,4 +75,22 @@ } return result; } + + public static Set<String> loadSanctionedClassNames( + Iterable<SanctionedSerializablesService> services) { + Set<String> sanctionedClasses = new HashSet<>(650); Review comment: Want to define a constant for 650? Is 650 the current size of the known sanctioned classes? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
