kirklund commented on a change in pull request #7177:
URL: https://github.com/apache/geode/pull/7177#discussion_r766022472
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/BrokenSerializationConsistencyRegressionTest.java
##########
@@ -15,8 +15,8 @@
package org.apache.geode.internal.cache;
import static org.apache.geode.cache.RegionShortcut.REPLICATE;
+import static
org.apache.geode.internal.lang.SystemPropertyHelper.DEFAULT_PREFIX;
Review comment:
I was trying to keep SystemPropertyHelper as a complete API such that
any geode-core class that uses SystemPropertyHelper does not also need to
import and use SystemProperty. We can however change the geode-core classes to
use both classes.
I personally don't like SystemPropertyHelper. I think it should be deleted
after moving all of the system properties into the classes that "own" those
properties. Then those classes would use SystemProperty only for the dual
prefixes of "geode." and "gemfire."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
