jvarenina opened a new pull request #7193: URL: https://github.com/apache/geode/pull/7193
Oplogs that are recovered after Region.close() will never be marked as eligible for compaction. This is because during recovery of the region the counter unrecoveredRegionCount is not cleared. When AbstractDiskRegionInfo object contained in Oplog is recovered then unrecoveredRegionCount should be decreased. This counter is decreased only if AbstractDiskRegionInfo.unrecovered is set to true for the object that is about to be recover (check checkForRecoverableRegion function). Problem is that these objects are deleted in Region.close(DiskRegion) and then recreated during recovery with flag unrecoverd set to false. Due to this unrecoveredRegionCount for the Oplog is not decreased after the recovery.This issue doesn't happen when cache/server is restarted because in that case this counter will be cleared. Solution: During close() mark all DiskRegion info objects as unrecovered in all Oplog's that are not yet compacted. After region is recovered then flag unrecovered is check and the counter checkForRecoverableRegion will be decreased. <!-- Thank you for submitting a contribution to Apache Geode. --> <!-- In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: --> ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? <!-- Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to [email protected]. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
