kirklund commented on a change in pull request #7189: URL: https://github.com/apache/geode/pull/7189#discussion_r768207881
########## File path: geode-serialization/src/main/java/org/apache/geode/internal/serialization/filter/SerializableObjectConfig.java ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.internal.serialization.filter; + +/** + * Defines the configuration properties for serialization filtering in Geode. + */ +public interface SerializableObjectConfig { + + default String getSerializableObjectFilterIfEnabled() { + return getValidateSerializableObjects() ? getSerializableObjectFilter() : null; + } + + boolean getValidateSerializableObjects(); + + void setValidateSerializableObjects(boolean value); + + String getSerializableObjectFilter(); Review comment: `DistributionConfig` defines all of the methods that geode-core needs to call including `setSerializableObjectFilter` and `setValidateSerializableObjects`. We have lots of tests that are setting `serializable-object-filter`. Take a look at the callers of `DistributionConfig.setSerializableObjectFilter`. `SerializableObjectConfig` defines only the methods of `DistributionConfig` that geode-serialization needs to call and it does not currently need to invoke `setSerializableObjectFilter`. The next PR invokes `setValidateSerializableObjects` from geode-serialization but not `setSerializableObjectFilter`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
