Kris-10-0 commented on a change in pull request #7172:
URL: https://github.com/apache/geode/pull/7172#discussion_r765310536
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -94,6 +101,16 @@ public RedisSet(int size) {
return diff;
}
+ private static int setOpStoreResult(RegionProvider regionProvider, RedisKey
destinationKey,
+ Set<byte[]> diff) {
+ if (diff.isEmpty()) {
+ regionProvider.getDataRegion().remove(destinationKey);
+ } else {
+ regionProvider.getLocalDataRegion().put(destinationKey, new
RedisSet(diff));
Review comment:
Thanks! I'll let you know if I need help.
I was following zunionstore and zinterstore in RedisSortedSet that was using
this method of storing the members of the key. Should a JIRA ticket be create
to change how those members are stored? I feel like another store method should
exist somewhere, maybe AbstractRedisData, to handle the case where it
overwrites the destination key.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
