pivotal-jbarrett commented on a change in pull request #901:
URL: https://github.com/apache/geode-native/pull/901#discussion_r769982258
##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -146,7 +146,10 @@ void Locator::start() {
}
void Locator::stop() {
- cluster_.getGfsh().stop().locator().withDir(name_).execute();
+ try {
+ cluster_.getGfsh().stop().locator().withDir(name_).execute();
+ } catch (...) {
Review comment:
Why are we eating exceptions in the teardown of the stopping of these
components? If there is an exception that should affect the test. If the
specific test wants to ignore the exceptions it would but it shouldn't be the
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
