jmelchio commented on a change in pull request #7207:
URL: https://github.com/apache/geode/pull/7207#discussion_r773159411
##########
File path:
geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/command/CloseCQ.java
##########
@@ -111,6 +112,13 @@ public void cmdExecute(final @NotNull Message
clientMessage,
sendCqResponse(MessageType.CQ_EXCEPTION_TYPE, "",
clientMessage.getTransactionId(), cqe,
serverConnection);
return;
+ } catch (AuthenticationExpiredException e) {
+ if (serverConnection.getTransientFlag(REQUIRES_CHUNKED_RESPONSE)) {
Review comment:
After a look at it I'm wondering if it wouldn't be better to use the
flag in deciding how to write the response. If at some point in the future the
flag changes we'd also still have to change the code downstream if we don't
read the flag when deciding how to write the exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]