mreddington commented on a change in pull request #901:
URL: https://github.com/apache/geode-native/pull/901#discussion_r777568726
##########
File path: cppcache/integration/framework/Cluster.cpp
##########
@@ -146,7 +146,10 @@ void Locator::start() {
}
void Locator::stop() {
- cluster_.getGfsh().stop().locator().withDir(name_).execute();
+ try {
+ cluster_.getGfsh().stop().locator().withDir(name_).execute();
+ } catch (...) {
Review comment:
Destructors aren't supposed to throw. We throw an exception when
BOOST_PROCESS tries to execute a command on a locator and the locator is
already down. This has absolutely nothing to do with the test itself or the
native client. We aren't testing the cluster, the testing framework itself, or
the environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
