DonalEvans commented on a change in pull request #7124:
URL: https://github.com/apache/geode/pull/7124#discussion_r779958287
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/partitioned/rebalance/model/PartitionedRegionLoadModel.java
##########
@@ -468,6 +507,41 @@ public Move findBestTarget(Bucket bucket, boolean
checkIPAddress) {
return bestMove;
}
+ String getRedundancyZone(InternalDistributedMember memberID) {
+ assert (partitionedRegion != null);
Review comment:
I would argue that if a test is not supplying a partitioned region, then
the test hasn't been written properly and throwing the NPE on the next line
should be fine. Changing it to any other kind of exception doesn't really solve
anything, just makes it fail in a different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
