dschneider-pivotal commented on a change in pull request #7257:
URL: https://github.com/apache/geode/pull/7257#discussion_r782633334
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -108,21 +104,18 @@ public static int sdiffstore(RegionProvider
regionProvider, RedisKey destination
private static MemberSet calculateDiff(RegionProvider regionProvider,
List<RedisKey> keys,
boolean updateStats) {
RedisSet firstSet = regionProvider.getTypedRedisData(REDIS_SET,
keys.get(0), updateStats);
+ MemberSet diff = new MemberSet();
if (firstSet.scard() == 0) {
- return null;
+ return diff;
}
- MemberSet diff = new MemberSet(firstSet.members);
+ diff = new MemberSet(firstSet.members);
for (int i = 1; i < keys.size(); i++) {
RedisSet curSet = regionProvider.getTypedRedisData(REDIS_SET,
keys.get(i), updateStats);
if (curSet.scard() == 0) {
Review comment:
Since we never store a empty RedisSet (if it is empty it just gets
removed) scard will never return 0. You should delete this if block.
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java
##########
@@ -108,21 +104,18 @@ public static int sdiffstore(RegionProvider
regionProvider, RedisKey destination
private static MemberSet calculateDiff(RegionProvider regionProvider,
List<RedisKey> keys,
boolean updateStats) {
RedisSet firstSet = regionProvider.getTypedRedisData(REDIS_SET,
keys.get(0), updateStats);
+ MemberSet diff = new MemberSet();
if (firstSet.scard() == 0) {
Review comment:
Since we never store a empty RedisSet (if it is empty it just gets
removed) scard will never return 0. You should delete this if block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
