DonalEvans commented on a change in pull request #7261:
URL: https://github.com/apache/geode/pull/7261#discussion_r788180489
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -286,6 +289,12 @@
ZUNIONSTORE(new ZUnionStoreExecutor(), SUPPORTED,
new Parameter().min(4).flags(WRITE, DENYOOM, MOVABLEKEYS)),
+ /************** Lists *****************/
+
+ LLEN(new LLenExecutor(), SUPPORTED, new Parameter().exact(2).flags(READONLY,
FAST)),
+ LPOP(new LPopExecutor(), SUPPORTED, new Parameter().min(2).flags(WRITE,
FAST)),
Review comment:
This will result in incorrect information being returned by the COMMAND
command though, since that parses the contents of `RedisCommandType` to
generate its output. We only accept exactly 2 arguments for the LPOP command,
so that's what should be returned by the COMMAND command, and hence what should
be set here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
