kirklund commented on a change in pull request #7299:
URL: https://github.com/apache/geode/pull/7299#discussion_r792249281
##########
File path:
geode-serialization/src/test/java/org/apache/geode/internal/serialization/filter/ReflectiveFacadeGlobalSerialFilterFactoryTest.java
##########
@@ -41,8 +49,9 @@ public void constructsDelegatingGlobalSerialFilter() {
public void delegatesToObjectInputFilterApiToCreateObjectInputFilter()
throws InvocationTargetException, IllegalAccessException {
ObjectInputFilterApi api = mock(ObjectInputFilterApi.class);
- GlobalSerialFilterFactory factory = new
ReflectiveFacadeGlobalSerialFilterFactory(api);
- GlobalSerialFilter filter = factory.create("pattern", emptySet());
+ ReflectiveFacadeGlobalSerialFilterFactory factory =
+ new ReflectiveFacadeGlobalSerialFilterFactory();
+ GlobalSerialFilter filter = factory.create(api, "pattern", emptySet());
Review comment:
Yeah, after reviewing this test class myself, I'm really not happy with
where it's currently at.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
