ringles commented on a change in pull request #7261: URL: https://github.com/apache/geode/pull/7261#discussion_r794943258
########## File path: geode-for-redis/src/test/java/org/apache/geode/redis/internal/data/collections/SizeableByteArrayListTest.java ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.data.collections; + +import static org.assertj.core.api.Assertions.assertThat; + +import org.junit.Before; +import org.junit.Test; + +import org.apache.geode.cache.util.ObjectSizer; +import org.apache.geode.internal.size.ReflectionObjectSizer; + +public class SizeableByteArrayListTest { + private final ObjectSizer sizer = ReflectionObjectSizer.getInstance(); + + @Before + public void setup() {} Review comment: Removed. ########## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/data/AbstractMemoryOverheadIntegrationTest.java ########## @@ -239,7 +276,7 @@ private void measureAndCheckPerEntryOverhead(AddEntryFunction addEntry, Measurem // Put some entries to make sure we initialize any constant size data structures. We are // just trying to measure the cost of each add entry operation. for (int i = 0; i < WARM_UP_ENTRY_COUNT; i++) { - String uniqueString = String.format("warmup-%10d", i); + String uniqueString = String.format("warmup-%010d", i); Review comment: It was deliberate, because it could produce string with spaces in them which confused the earlier version of the LPUSh executor. It's no longer necessary thanks to later development. Good catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
