pivotal-jbarrett commented on pull request #7315: URL: https://github.com/apache/geode/pull/7315#issuecomment-1027262785
@upthewaterspout > I do think maybe some integration/acceptance testing is needed here. IE if I start a GemFire peer or server is it actually using the ssl protocols that a user has configured? Seems like that was not happening before. Writing tests at this level would require either log scraping or punching dirty holes through the interfaces to get to the `SSLEngine` objects. I have written an integration tests that tests the `SocketCreator.createSSLEngine()` that asserts the `SSLEngine` is configured as expected. I believe these should be sufficient integration coverage for any code path that uses this method to construct its `SSLEngine`, any path that does something else isn't affected by this issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
