gaussianrecurrence opened a new pull request #920:
URL: https://github.com/apache/geode-native/pull/920


    - Currently, in the native client, if you configure retryAttemps to be >0 
for your pool, non-HA function executions are retried. 
       This happens as retry are coded in the network layer.
    - Geode documentation states that retries should happen for functions
      which isHA=true and in the function execution logic. And this is how
      it works in the Java client API.
    - If a function is retried at the network layer, it could happen that 
    - So, this commit changes the behavior, so non-HA functions are not
      retried.
    - Also, FunctionAttributes were introduced in order to improve code
      readability.
    - Moved function execution classes to a file of its own, in order to
      improve readability and modularity.
    - Solved a bug in which there could not exist 2 functions with the same
      name, defined on different clusters and with different function
      attributes.
    - Implemented several new ITs to test that non-HA function executions are 
not
      retried by the API.
    - These are the cases being tested:
       * Function execution with PR enabled:
         - A timeout is forced from the server-side, so the server closes
           the connection towards the client.
         - A timeout is forced in the client.
       * Function execution with PR disabled.
   
   
   Co-authored-by: Jakov Varenina <jakov.varen...@est.tech>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to