DonalEvans commented on a change in pull request #7261:
URL: https://github.com/apache/geode/pull/7261#discussion_r800974904
##########
File path:
geode-for-redis/src/distributedTest/java/org/apache/geode/redis/internal/commands/executor/list/LPushDUnitTest.java
##########
@@ -64,71 +71,54 @@ public static void tearDown() {
}
@Test
- public void shouldDistributeDataAmongCluster() {
+ public void lpush_ShouldPushMultipleElementsAtomically()
Review comment:
This test is not testing distributed behaviour, as all the operations
are being done to a list residing in a bucket that does not move during the
test, and no validation of the contents of the secondary copy is done. This
would be a decent integration test to add to `AbstractLPushIntegrationTest`
(possibly refactored a little to use `ConcurrentLoopingThreads` rather than the
`ExecutorServiceRule`, just to be consistent with other Integration tests), but
in order to test distributed behaviour, we need to be either moving buckets
directly or crashing servers to cause them to move, and doing some verification
that the contents of the secondary bucket after failing over matches what we
expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
