upthewaterspout commented on a change in pull request #7346:
URL: https://github.com/apache/geode/pull/7346#discussion_r801175701
##########
File path:
geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/MemberIdentifierImpl.java
##########
@@ -676,7 +675,14 @@ public void toDataPre_GFE_9_0_0_0(DataOutput out,
SerializationContext context)
durableId == null ? 300 : memberData.getDurableTimeout(),
out);
- short version = memberData.getVersionOrdinal();
+ final short version;
+ if (context.getSerializationVersion().isNewerThan(KnownVersion.GFE_90)) {
+ version = memberData.getVersionOrdinal();
+ } else {
+ // This version of geode-native could not parse the longer version
ordinals.
+ // Let's make these older clients think the server is still 1.14.
+ version = KnownVersion.GEODE_1_14_0.ordinal();
Review comment:
The version here is the version of this MemberIdentifierImpl object,
which may or may not be the member currently executing this code. It could be a
MemberIdentifierImpl from a peer, or even from a client or WAN site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
