mmartell commented on a change in pull request #918:
URL: https://github.com/apache/geode-native/pull/918#discussion_r801207149



##########
File path: cppcache/src/Log.cpp
##########
@@ -369,6 +372,46 @@ LogLevel Log::charsToLevel(const std::string& chars) {
   }
 }
 
+void Log::setThreadName(const std::string& threadName) {

Review comment:
       Need to leave this alone because of the try/except block. If string is 
not const we get this error:
   
   Error        C2712   Cannot use __try in functions that require object 
unwinding     apache-geode-static     C:\temp\geode-native\cppcache\src\Log.cpp 
      413




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to