jdeppe-pivotal opened a new pull request #7354:
URL: https://github.com/apache/geode/pull/7354
- This adds a single category (or type) to each command in order to
identify the type of data structure it applies too. This is initially
being done in order to allow Geode statistics to be finer grained in
how the Radish-specific stats are grouped.
- The category is derived from Redis' ACL Categories. In Redis these
categories also include the command's flags (and possibly additional
values). This implementation only specifies the category as it relates
to the command's data type. For example, in Redis the `GET` command
has categories `@read`, `@fast` and `@string`. In Geode, the category
would only be `@string`. This may well change in the future if ACLs
are implemented.
<!-- Thank you for submitting a contribution to Apache Geode. -->
<!-- In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
-->
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
<!-- Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to [email protected].
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
