ryangardner commented on a change in pull request #7351:
URL: https://github.com/apache/geode/pull/7351#discussion_r804079070



##########
File path: geode-core/build.gradle
##########
@@ -420,4 +420,10 @@ distributedTest {
   exclude "**/*\$*.class"
 }
 
+rootProject.combineReports.dependsOn(':geode-old-versions:test')

Review comment:
       Without that dependency declared, it fails with the following error 
message: 
   
   ```
   > Task :geode-core:test FAILED
   
   > Task :combineReports
   Execution optimizations have been disabled for task ':combineReports' to 
ensure correctness due to the following reasons:
     - Gradle detected a problem with the following location: 
'geode/geode-old-versions/build/test-results/test/binary'. Reason: Task 
':combineReports' uses this output of task ':geode-old-versions:test' without 
declaring an explicit or implicit dependency. This can lead to incorrect 
results being produced, depending on what order the tasks are executed. Please 
refer to 
https://docs.gradle.org/7.4/userguide/validation_problems.html#implicit_dependency
 for more details about this problem.
   ```
   
   The combine reports task seems to depend upon things coming from the 
old-versions - there are some IP bind failures (three actual test failures) in 
the geode-core tests for me as well so it's not clear if this message would 
just be considered a warning or not.
   
   There might be a way to modify the `:combineReports` task to make it not use 
the output of the `geode-old-versions:test` if it doesn't need to run that test 
and that would also get rid of that warning.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to