pivotal-jbarrett commented on a change in pull request #7315:
URL: https://github.com/apache/geode/pull/7315#discussion_r805073666
##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/SSLConfig.java
##########
@@ -67,26 +73,30 @@
@Immutable
private final SSLParameterExtension sslParameterExtension;
- private SSLConfig(boolean endpointIdentification,
- boolean useDefaultSSLContext,
- boolean enabled,
- String protocols,
- String ciphers,
- boolean requireAuth,
- String keystore,
- String keystoreType,
- String keystorePassword,
- String truststore,
- String truststorePassword,
- String truststoreType,
- String alias,
- SecurableCommunicationChannel securableCommunicationChannel,
- Properties properties,
- SSLParameterExtension sslParameterExtension) {
+ private SSLConfig(final boolean endpointIdentification,
+ final boolean useDefaultSSLContext,
+ final boolean enabled,
+ final @NotNull String protocols,
+ final @Nullable String clientProtocols,
+ final @Nullable String serverProtocols,
+ final String ciphers,
+ final boolean requireAuth,
+ final String keystore,
+ final String keystoreType,
+ final String keystorePassword,
+ final String truststore,
+ final String truststorePassword,
+ final String truststoreType,
+ final String alias,
+ final SecurableCommunicationChannel securableCommunicationChannel,
+ final Properties properties,
+ final SSLParameterExtension sslParameterExtension) {
this.endpointIdentification = endpointIdentification;
this.useDefaultSSLContext = useDefaultSSLContext;
this.enabled = enabled;
this.protocols = protocols;
Review comment:
Good catch and question. I wasn't sure how it was used in that
deprecated `toDSProperties` method, which is only used by the mostly deprecated
JMX admin stuff in `RemoteTransportConfig`. I sort of drew a line in the sand
that I wasn't going to go there. I could either mark the property as
`@Deprecated` for removal when that old admin stuff is removed, or propagate
the `ssl-client-protocols` value there instead. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
