jinmeiliao commented on a change in pull request #7357:
URL: https://github.com/apache/geode/pull/7357#discussion_r805081423
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ServerConnection.java
##########
@@ -959,9 +960,12 @@ public boolean isTerminated() {
}
}
- private void cleanClientAuths() {
+ // this needs to be synchronized to avoid NPE betweeen null check and cleanup
+ @VisibleForTesting
+ synchronized void cleanClientAuths() {
Review comment:
Good suggestion. added the lock and then removed all the NPE try/catch
blocks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
