pdxcodemonkey commented on a change in pull request #917:
URL: https://github.com/apache/geode-native/pull/917#discussion_r806084212
##########
File path: cmake/FindGeode.cmake
##########
@@ -73,7 +73,8 @@ if(Geode_gfsh_EXECUTABLE)
# TODO error checking
else()
if(var MATCHES "([0-9]+\\.[0-9]+\\.[0-9]+)")
- set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION "${CMAKE_MATCH_1}")
+ set(Geode_VERSION_FULL ${var})
Review comment:
Unless I'm mistaken, nothing in this change depends on Geode_VERSION any
more, so there should be no changes necessary in this file. Please remove, we
don't want to accidentally introduce any new ways to break the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
