DonalEvans commented on a change in pull request #7340:
URL: https://github.com/apache/geode/pull/7340#discussion_r809235663
##########
File path:
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/pubsub/AbstractSubscriptionsIntegrationTest.java
##########
@@ -74,9 +74,6 @@ public void pingWithArgumentWhileSubscribed() {
executor.submit(() -> client.subscribe(mockSubscriber, "same"));
mockSubscriber.awaitSubscribe("same");
mockSubscriber.ping("potato");
- // JedisPubSub PING with message is not currently possible, will submit a
PR
- // (https://github.com/xetorthio/jedis/issues/2049)
- // until then, we have to call this second ping to flush the client
mockSubscriber.ping();
Review comment:
This second ping should also be removed, as it's no longer necessary,
and the assertion on line 79 should be changed from `isEqualTo(2)` to `isOne()`
##########
File path:
geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/sortedset/AbstractZUnionStoreIntegrationTest.java
##########
@@ -435,30 +436,30 @@ public void shouldUnionize_givenSetsPartiallyOverlap() {
Map<String, Double> scores2 = makeScoreMap(5, 1, 10, x -> (double) (x < 10
? x : x * 2));
jedis.zadd(KEY2, scores2);
- Set<Tuple> expectedResults = convertToTuples(makeScoreMap(0, 1, 15, x ->
(double) x),
+ final List<Tuple> expectedResults = convertToTuples(makeScoreMap(0, 1, 15,
x -> (double) x),
(i, x) -> (double) (i < 5 ? i : i * 2));
jedis.zunionstore(NEW_SET, KEY1, KEY2);
- Set<Tuple> results = jedis.zrangeWithScores(NEW_SET, 0, 20);
+ final List<Tuple> results = jedis.zrangeWithScores(NEW_SET, 0, 20);
assertThat(results).containsExactlyElementsOf(expectedResults);
}
@Test
- public void ensureWeightsAreAppliedBeforeAggregation() {
+ public void ensureWeightsAreAppliedBeforeAxggregation() {
Review comment:
Typo here, "Axggregation" should be "Aggregation"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
