DonalEvans commented on a change in pull request #7362:
URL: https://github.com/apache/geode/pull/7362#discussion_r810165511
##########
File path:
geode-for-redis/src/distributedTest/java/org/apache/geode/redis/OutOfMemoryDUnitTest.java
##########
@@ -181,7 +182,7 @@ public void
shouldReturnOOMError_forWriteOperations_whenThresholdReached() {
await()
.untilAsserted(() -> assertThatThrownBy(() -> jedis.set(server1Tag +
"oneMoreKey", "value"))
- .hasMessageContaining("OOM"));
+ .hasMessage("OOM " + ERROR_OOM_COMMAND_NOT_ALLOWED));
Review comment:
It might make sense to make "OOM", "ERR" and "WRONGTYPE" just part of
the error string. We currently have multiple flavours of "getXResponse" methods
in `Coder` which just tack a different string onto the beginning of the error
message. We could simplify things a fair bit by baking that prefix into the
error message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
