jinmeiliao commented on pull request #7395: URL: https://github.com/apache/geode/pull/7395#issuecomment-1051129631
> Do not mock the thing being tested. `CliFunction` is designed to be extended. So make the test create a derived class, and make its `executeFunction` method throw. > > I'm honestly astonished that the `CliFunction` test passes, given that it's testing a mock. My guess is that the mock is behaving like a spy. yeah, I changed back to use a spy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
