dschneider-pivotal commented on a change in pull request #7396:
URL: https://github.com/apache/geode/pull/7396#discussion_r815158133
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
##########
@@ -92,6 +93,19 @@ public int llen() {
return elementList.size();
}
+ /**
+ * @param region, the region to set on
+ * @param key, the key to set on
+ * @param index, the adjusted index to set (adjusted to a positive index)
+ * @param value, the value to set
+ * @return boolean if set
+ */
+ public boolean lset(Region<RedisKey, RedisData> region, RedisKey key, int
index, byte[] value) {
+ byte[] delta = elementList.set(index, value);
+ storeChanges(region, key, new ReplaceByteArrayAtOffset(index, delta));
Review comment:
You don't want to ship the oldValue returned by "set" as the value in
that delta. You can ignore the value returned by "set" (get rid of the "delta"
variable) and pass "value" to the ReplaceByteArrayAtOffset constructor.
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LSetExecutor.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.commands.executor.list;
+
+import static
org.apache.geode.redis.internal.RedisConstants.ERROR_INDEX_OUT_OF_RANGE;
+import static org.apache.geode.redis.internal.RedisConstants.ERROR_NO_SUCH_KEY;
+
+import java.util.List;
+
+import org.apache.geode.cache.Region;
+import org.apache.geode.redis.internal.commands.Command;
+import org.apache.geode.redis.internal.commands.executor.CommandExecutor;
+import org.apache.geode.redis.internal.commands.executor.RedisResponse;
+import org.apache.geode.redis.internal.data.RedisData;
+import org.apache.geode.redis.internal.data.RedisKey;
+import org.apache.geode.redis.internal.data.RedisList;
+import org.apache.geode.redis.internal.netty.Coder;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class LSetExecutor implements CommandExecutor {
+ @Override
+ public RedisResponse executeCommand(Command command, ExecutionHandlerContext
context) {
+ Region<RedisKey, RedisData> region = context.getRegion();
+ List<byte[]> commandElements = command.getProcessedCommand();
+
+ RedisKey key = command.getKey();
+ if (!context.listLockedExecute(key, false, RedisData::exists)) {
+ return RedisResponse.error(ERROR_NO_SUCH_KEY);
+ }
+
+ long index = Coder.bytesToLong(commandElements.get(2));
+ byte[] value = commandElements.get(3);
+ long listSize = (long) context.listLockedExecute(key, false,
RedisList::llen);
+
+ final int adjustedIndex = (int) (index >= 0 ? index : listSize + index);
Review comment:
I agree that this code needs move into the "lset" method. Also the
LRANGE pull request is adding a new method that I think you can use to "adjust"
your index.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
