pivotal-jbarrett commented on a change in pull request #938:
URL: https://github.com/apache/geode-native/pull/938#discussion_r817971407
##########
File path: cppcache/src/TcrConnection.cpp
##########
@@ -380,33 +386,33 @@ bool TcrConnection::initTcrConnection(
}
switch (acceptanceCode[0]) {
- case REPLY_OK:
- case SUCCESSFUL_SERVER_TO_CLIENT:
+ case static_cast<int>(acceptance_codes::REPLY_OK):
Review comment:
If we have to static cast this switch case values than either
`acceptanceCode[0]` is the wrong type or all the values of `acceptanceType[0]`
are not covered by a single `enum` and the use of `enum` probably isn't
appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
