pivotal-jbarrett commented on a change in pull request #7262:
URL: https://github.com/apache/geode/pull/7262#discussion_r819190801
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/DistributedPutAllOperation.java
##########
@@ -80,15 +80,15 @@
public int putAllDataSize;
- protected boolean isBridgeOp = false;
+ protected boolean isBridgeOp;
static final byte USED_FAKE_EVENT_ID = 0x01;
static final byte NOTIFY_ONLY = 0x02;
static final byte FILTER_ROUTING = 0x04;
static final byte VERSION_TAG = 0x08;
static final byte POSDUP = 0x10;
static final byte PERSISTENT_TAG = 0x20;
- static final byte HAS_CALLBACKARG = 0x40;
+ // static final byte HAS_CALLBACKARG = 0x40;
Review comment:
Good question. I left it in there not as commented out code but as
documentation for what values we believe this protocol message to have but
aren't utilizing. I could make that more clear by removing that type and
modifiers I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
