jchen21 commented on a change in pull request #7375:
URL: https://github.com/apache/geode/pull/7375#discussion_r819790167
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/UpdateAttributesProcessor.java
##########
@@ -393,7 +393,7 @@ public static void send(InternalDistributedMember
recipient, int processorId,
if (exception != null) {
m.setException(exception);
if (logger.isDebugEnabled()) {
- logger.debug("Replying with exception: {}" + m, exception);
+ logger.debug("Replying with exception: {}", m, exception);
Review comment:
Missing `{}` here.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/UpdateAttributesProcessor.java
##########
@@ -462,7 +462,7 @@ public static void send(InternalDistributedMember
recipient, int processorId,
if (exception != null) {
m.setException(exception);
if (logger.isDebugEnabled()) {
- logger.debug("Replying with exception: {}" + m, exception);
+ logger.debug("Replying with exception: {}", m, exception);
Review comment:
Missing `{}` here.
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/EntryExpiryTask.java
##########
@@ -326,10 +326,9 @@ protected void basicPerformTimeout(boolean isPending)
throws CacheException {
}
if (hasExpired(getNow(), expTime)) {
if (logger.isTraceEnabled()) {
- // NOTE: original finer message used this.toString() twice
logger.trace(
- "{}.performTimeout().getExpirationTime() is {}; {}.expire({}).
ttlExpiration: {}, idleExpiration: {}, ttlAttrs: {}, idleAttrs: {} action is:
{}",
- this, expTime, this, action, ttl, idle, getTTLAttributes(),
getIdleAttributes());
+ "{}.performTimeout().getExpirationTime() is {};
ttlExpiration:{}, idleExpiration:{}, ttlAttrs:{}, idleAttrs:{} action is:{}",
Review comment:
`this` is passed as parameter for
`{}.performTimeout().getExpirationTime()`. It will call
`EntryExpiryTask.toString()` which returns a long string description with
spaces. It is not easy to read. Perhaps passing
`this.getClass().getSimpleName()` would be better. And the method name should
be `basicPerformTimeout` instead of `performTimeout()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
