jdeppe-pivotal commented on a change in pull request #7429:
URL: https://github.com/apache/geode/pull/7429#discussion_r822115655
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/AbstractRedisData.java
##########
@@ -218,7 +230,14 @@ public void toDelta(DataOutput out) throws IOException {
@Override
public void fromDelta(DataInput in) throws IOException,
InvalidDeltaException {
+ short deltaVersion = DataSerializer.readPrimitiveShort(in);
DeltaType deltaType = readEnum(DeltaType.class, in);
+
+ if (deltaType.isVersioned() && deltaVersion == getVersion()) {
+ return;
+ }
+ setVersion(deltaVersion);
Review comment:
Right. So I've pulled the version increment out of that method into the
actual `RedisString.append` call. That way the delta application won't cause a
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
